LGTM. Reviewed-by: Dom Rodriguez <shymega@shymega.org.uk> On 08.09.2024 16:47, Alyssa Ross wrote:
The standard says the following, so I don't think it's specified that it's allowed to be in an include file:
If it appears as the first non-comment line in the makefile, make shall process the makefile as specified by this section; otherwise, the behavior of make is unspecified.
Link: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/make.html#tag_20_... Fixes: c3fbeca ("lib/common.mk: init") Signed-off-by: Alyssa Ross <hi@alyssa.is> --- host/initramfs/Makefile | 2 ++ host/rootfs/Makefile | 2 ++ img/app/Makefile | 2 ++ lib/common.mk | 2 -- release/live/Makefile | 2 ++ vm/sys/net/Makefile | 2 ++ 6 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/host/initramfs/Makefile b/host/initramfs/Makefile index 06f69b3..8382296 100644 --- a/host/initramfs/Makefile +++ b/host/initramfs/Makefile @@ -1,6 +1,8 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross <hi@alyssa.is>
+.POSIX: + include ../../lib/common.mk
dest = build/initramfs diff --git a/host/rootfs/Makefile b/host/rootfs/Makefile index f4fb7a4..2f4445d 100644 --- a/host/rootfs/Makefile +++ b/host/rootfs/Makefile @@ -1,6 +1,8 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2021-2024 Alyssa Ross <hi@alyssa.is>
+.POSIX: + include ../../lib/common.mk
dest = build/rootfs.erofs diff --git a/img/app/Makefile b/img/app/Makefile index 3adf8c4..79dd22e 100644 --- a/img/app/Makefile +++ b/img/app/Makefile @@ -2,6 +2,8 @@ # SPDX-FileCopyrightText: 2021-2024 Alyssa Ross <hi@alyssa.is> # SPDX-FileCopyrightText: 2022 Unikie
+.POSIX: + include ../../lib/common.mk
prefix = build/host diff --git a/lib/common.mk b/lib/common.mk index 8f11ecc..7733878 100644 --- a/lib/common.mk +++ b/lib/common.mk @@ -1,8 +1,6 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2021, 2023 Alyssa Ross <hi@alyssa.is>
-.POSIX: - # qemu-kvm is non-standard, but is present in at least Fedora and # Nixpkgs. If you don't have qemu-kvm, you'll need to set e.g. # QEMU_KVM = qemu-system-x86_64 -enable-kvm. diff --git a/release/live/Makefile b/release/live/Makefile index f45870d..a8c81c3 100644 --- a/release/live/Makefile +++ b/release/live/Makefile @@ -1,6 +1,8 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2021-2023 Alyssa Ross <hi@alyssa.is>
+.POSIX: + include ../../lib/common.mk
dest = build/live.img diff --git a/vm/sys/net/Makefile b/vm/sys/net/Makefile index 00757db..2c2f084 100644 --- a/vm/sys/net/Makefile +++ b/vm/sys/net/Makefile @@ -1,6 +1,8 @@ # SPDX-License-Identifier: EUPL-1.2+ # SPDX-FileCopyrightText: 2021-2024 Alyssa Ross <hi@alyssa.is>
+.POSIX: + include ../../../lib/common.mk
prefix = build/svc
base-commit: 0f5cfe23285d31c3f7ea1d0fbca967fa8bae8d59 -- 2.45.2
Best wishes, -- Dom Rodriguez GPG Fingerprint: EB0D 45E6 D0DC 1BA1 A2B5 FC24 72DC F123 1E54 BD43