On Tue, Jun 07, 2022 at 06:52:00AM -0000, Ville Ilvonen wrote:
Hi,
Thanks for the review comments and no worries with delay. People have their schedules. I was just following up on this contrib :-)
Thanks! I'm ready to apply this patch. One small thing that needs to be addressed first: the diagram file is missing a license notice, so my `reuse lint` check fails. Is the same license as used for the documentation file itself (GFDL-1.3-no-invariants-or-later OR CC-BY-SA-4.0) okay? No need to send a new patch just to add the license notice — I can add it when I apply the patch.
I was quite not sure how you would have preferred the changes implemented - amended to the original patch or additional patch. I used additional patch. As hard line wrap destroys the diff in respect to the earlier patch I addressed your review comments in the patch comments and used git-send to add the patch. I don't mind amending the changes to the original patch either, just let me know.
If there's different preferences, we could complement the contribution guidelines and include style guide.
Good idea. I'll write it up when I get the chance, but in short, the preferred way to do this is to send a new version of the whole patch, with "[PATCH v2]" at the start of the subject line (the -v2 argument to git format-patch or git send-email will do this), and to explain the changes from the previous version after the "---" line, just before the diffstat. (This is called the "timely commentary" section because it's stripped when the final version of the patch is applied by git.)