Alyssa Ross <hi@alyssa.is> writes:
This errored because of the undefined XDG_RUNTIME_DIR or WAYLAND_DISPLAY. I'd tried to prevent that by disabling -e around this part, but it turns out I should have disabled -u instead. --- pkgs/os-specific/linux/spectrum/spectrum-vm/spectrum-vm.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pkgs/os-specific/linux/spectrum/spectrum-vm/spectrum-vm.in b/pkgs/os-specific/linux/spectrum/spectrum-vm/spectrum-vm.in index 4fa0287a805..8d95c178689 100755 --- a/pkgs/os-specific/linux/spectrum/spectrum-vm/spectrum-vm.in +++ b/pkgs/os-specific/linux/spectrum/spectrum-vm/spectrum-vm.in @@ -55,7 +55,7 @@ do esac done
-set +e +set +u if [ -n "$XDG_RUNTIME_DIR" ]
Rather than using `set`, I, personally, would change this line to be: if [ -n "${XDG_RUNTIME_DIR:-}" ] (as well as the matching check for $WAYLAND_DISPLAY). Though this is just a matter of opinion, I think it is cleaner than using `set`s (but only really because I have no idea what all the `set`s do, without context).
then set -- -s "$XDG_RUNTIME_DIR" "$@" @@ -63,7 +63,7 @@ then then set -- --wayland-sock "$XDG_RUNTIME_DIR/$WAYLAND_DISPLAY" "$@" fi fi -set -e +set -u
exec "$crosvm" run \ -p init=/sbin/init \ -- 2.27.0
Cole