"Cole Helbling" <cole.e.helbling@outlook.com> writes:
On Fri Apr 9, 2021 at 3:20 PM PDT, Alyssa Ross wrote:
This adds a mac= option to crosvm's --tap-fd option. The virtio-net driver in the guest will read the desired MAC from virtio configuration space.
See the documentation for VIRTIO_NET_F_MAC in the Virtio spec[1].
[1]: https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html
--- This will be important for host-based networking in Spectrum.
devices/src/virtio/net.rs | 31 ++++++++++++++++--- src/crosvm.rs | 8 +++-- src/linux.rs | 20 +++++++----- src/main.rs | 64 ++++++++++++++++++++++++++++++--------- 4 files changed, 96 insertions(+), 27 deletions(-)
Probably should have reviewed this one first... :P Oh well.
Reviewed-by: Cole Helbling <cole.e.helbling@outlook.com>
Thanks, I've added your r-b to the patch file in the inter-guest networking series.