[PATCH] release/checks/integration: add nc timeout
I recently saw a transient timeout of this test. Looking at the logs, it seems like, before netvm was rebooted, nc was already running, and that nc never failed, getting stuck. Presumably, if it had failed, another nc run would have connected successfully. Avoid this by setting a 2 second timeout for nc to ensure this eternal hang can't happen. Reported-by: Demi Marie Obenour <demiobenour@gmail.com> Link: https://spectrum-os.org/lists/archives/spectrum-devel/f52c1aa7-96c0-462b-928... Fixes: ae45978 ("release/checks/networking: init") Signed-off-by: Alyssa Ross <hi@alyssa.is> --- release/checks/integration/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/checks/integration/default.nix b/release/checks/integration/default.nix index 340fb6e..81db264 100644 --- a/release/checks/integration/default.nix +++ b/release/checks/integration/default.nix @@ -19,7 +19,7 @@ let type = "nix"; run = writeShellScript "run" '' set -x - while :; do echo hello | ${libressl.nc}/bin/nc -N 10.0.2.2 1234; done + while :; do echo hello | ${libressl.nc}/bin/nc -Nw 2 10.0.2.2 1234; done ''; }; base-commit: b1bb4e5050b09a8edcafc0cf1b1b9c9ab42832bc -- 2.51.0
On 10/31/25 07:13, Alyssa Ross wrote:
I recently saw a transient timeout of this test. Looking at the logs, it seems like, before netvm was rebooted, nc was already running, and that nc never failed, getting stuck. Presumably, if it had failed, another nc run would have connected successfully. Avoid this by setting a 2 second timeout for nc to ensure this eternal hang can't happen.
Reported-by: Demi Marie Obenour <demiobenour@gmail.com> Link: https://spectrum-os.org/lists/archives/spectrum-devel/f52c1aa7-96c0-462b-928... Fixes: ae45978 ("release/checks/networking: init") Signed-off-by: Alyssa Ross <hi@alyssa.is> --- release/checks/integration/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/release/checks/integration/default.nix b/release/checks/integration/default.nix index 340fb6e..81db264 100644 --- a/release/checks/integration/default.nix +++ b/release/checks/integration/default.nix @@ -19,7 +19,7 @@ let type = "nix"; run = writeShellScript "run" '' set -x - while :; do echo hello | ${libressl.nc}/bin/nc -N 10.0.2.2 1234; done + while :; do echo hello | ${libressl.nc}/bin/nc -Nw 2 10.0.2.2 1234; done ''; };
base-commit: b1bb4e5050b09a8edcafc0cf1b1b9c9ab42832bc
That looks good to me. I would have expected a TCP timeout, but I'm not surprised it didn't happen. nc might even explicitly disable those unless a timeout is set. -- Sincerely, Demi Marie Obenour (she/her/hers)
This patch has been committed as c61b297b493a948f5ea469c568bffc61bdd5b1f3, which can be viewed online at https://spectrum-os.org/git/spectrum/commit/?id=c61b297b493a948f5ea469c568bf.... This is an automated message. Send comments/questions/requests to: Alyssa Ross <hi@alyssa.is>
participants (3)
-
Alyssa Ross -
Alyssa Ross -
Demi Marie Obenour