[PATCH www] impressum: fix broken relative paths in subdirectories
Signed-off-by: Angel J <iamanaws@httpd.dev> --- logo/index.html | 2 +- software/cloud-hypervisor/index.html | 2 +- software/index.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/logo/index.html b/logo/index.html index 0750053..2471cf9 100644 --- a/logo/index.html +++ b/logo/index.html @@ -61,4 +61,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small> <p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../impressum.html" lang="de"><small>Impressum</small></a> diff --git a/software/cloud-hypervisor/index.html b/software/cloud-hypervisor/index.html index 2fef585..0bda4a7 100644 --- a/software/cloud-hypervisor/index.html +++ b/software/cloud-hypervisor/index.html @@ -177,4 +177,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small> <p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../../impressum.html" lang="de"><small>Impressum</small></a> diff --git a/software/index.html b/software/index.html index a05e177..2a8a852 100644 --- a/software/index.html +++ b/software/index.html @@ -38,4 +38,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small> <p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../impressum.html" lang="de"><small>Impressum</small></a> -- 2.51.2
On 12/25/25 22:17, Angel J wrote:
Signed-off-by: Angel J <iamanaws@httpd.dev> --- logo/index.html | 2 +- software/cloud-hypervisor/index.html | 2 +- software/index.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/logo/index.html b/logo/index.html index 0750053..2471cf9 100644 --- a/logo/index.html +++ b/logo/index.html @@ -61,4 +61,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small>
<p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../impressum.html" lang="de"><small>Impressum</small></a> diff --git a/software/cloud-hypervisor/index.html b/software/cloud-hypervisor/index.html index 2fef585..0bda4a7 100644 --- a/software/cloud-hypervisor/index.html +++ b/software/cloud-hypervisor/index.html @@ -177,4 +177,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small>
<p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../../impressum.html" lang="de"><small>Impressum</small></a> diff --git a/software/index.html b/software/index.html index a05e177..2a8a852 100644 --- a/software/index.html +++ b/software/index.html @@ -38,4 +38,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small>
<p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../impressum.html" lang="de"><small>Impressum</small></a>
Nice catch! I wonder if automation can reduce the chance of similar problems. Could a template engine be used to reduce repetition? Or at least check that all of the internal links are valid? -- Sincerely, Demi Marie Obenour (she/her/hers)
On Fri Dec 26, 2025 at 9:37 PM CET, Demi Marie Obenour wrote:
Nice catch! I wonder if automation can reduce the chance of similar problems. Could a template engine be used to reduce repetition? Or at least check that all of the internal links are valid?
I wondered the same after finding these broken links recently (I just procrastinated sending a patch), and looked for tools to find broken links. I found a few, the one I liked most is lychee (https://github.com/lycheeverse/lychee). Using Nix, it can be run on the homepage repository as follows: nix-shell -p lychee --run 'lychee --root-dir $PWD .' Doing this, some broken external links can also be found. Some external links are being reported as broken erroneously for me, namely to gnu.org and doi.org. However, there are also two links which are broken: 1. On logo/index.html: https://hazelnot.xyz/ 2. On motivation.html: https://docs.saltstack.com/en/latest/ The website of Hazelnot seems to be offline since about June 2024, see https://web.archive.org/web/20240301000000*/https://hazelnot.xyz/ The documentation of Saltstack moved to a new domain. Qubes moved their docs too, although they have redirects in place. I have a patch for this already which will follow in a minute. Regarding the broken internal links, I wonder if we would be better off using absolute links to avoid copy-paste errors in the future?
Johannes Süllner <johannes.suellner@mailbox.org> writes:
On Fri Dec 26, 2025 at 9:37 PM CET, Demi Marie Obenour wrote:
Nice catch! I wonder if automation can reduce the chance of similar problems. Could a template engine be used to reduce repetition? Or at least check that all of the internal links are valid?
I wondered the same after finding these broken links recently (I just procrastinated sending a patch), and looked for tools to find broken links. I found a few, the one I liked most is lychee (https://github.com/lycheeverse/lychee).
Using Nix, it can be run on the homepage repository as follows: nix-shell -p lychee --run 'lychee --root-dir $PWD .'
Doing this, some broken external links can also be found. Some external links are being reported as broken erroneously for me, namely to gnu.org and doi.org. However, there are also two links which are broken: 1. On logo/index.html: https://hazelnot.xyz/ 2. On motivation.html: https://docs.saltstack.com/en/latest/
The website of Hazelnot seems to be offline since about June 2024, see https://web.archive.org/web/20240301000000*/https://hazelnot.xyz/ The documentation of Saltstack moved to a new domain. Qubes moved their docs too, although they have redirects in place. I have a patch for this already which will follow in a minute.
Regarding the broken internal links, I wonder if we would be better off using absolute links to avoid copy-paste errors in the future?
That would prevent navigating the website locally during development, so I'd rather not. It probably does make sense to move to a static site generator at some point though, especially if the website acquires more content.
Demi Marie Obenour <demiobenour@gmail.com> writes:
On 12/25/25 22:17, Angel J wrote:
Signed-off-by: Angel J <iamanaws@httpd.dev> --- logo/index.html | 2 +- software/cloud-hypervisor/index.html | 2 +- software/index.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/logo/index.html b/logo/index.html index 0750053..2471cf9 100644 --- a/logo/index.html +++ b/logo/index.html @@ -61,4 +61,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small>
<p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../impressum.html" lang="de"><small>Impressum</small></a> diff --git a/software/cloud-hypervisor/index.html b/software/cloud-hypervisor/index.html index 2fef585..0bda4a7 100644 --- a/software/cloud-hypervisor/index.html +++ b/software/cloud-hypervisor/index.html @@ -177,4 +177,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small>
<p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../../impressum.html" lang="de"><small>Impressum</small></a> diff --git a/software/index.html b/software/index.html index a05e177..2a8a852 100644 --- a/software/index.html +++ b/software/index.html @@ -38,4 +38,4 @@ by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts.</small>
<p> -<a href="impressum.html" lang="de"><small>Impressum</small></a> +<a href="../impressum.html" lang="de"><small>Impressum</small></a>
Nice catch! I wonder if automation can reduce the chance of similar problems. Could a template engine be used to reduce repetition? Or at least check that all of the internal links are valid?
You don't need a template engine for that! Take a look at release/checks/doc-links.nix in Spectrum, which checks internal links in the Spectrum documentation. It might be good to unify the documentation with the rest of the website, but I'm not sure yet. It feels a bit weird to have stuff that isn't about the Spectrum system inside the spectrum repo.
Angel J <iamanaws@httpd.dev> writes:
Signed-off-by: Angel J <iamanaws@httpd.dev> --- logo/index.html | 2 +- software/cloud-hypervisor/index.html | 2 +- software/index.html | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Applied, thank you! Sorry it took me a while.
participants (4)
-
Alyssa Ross -
Angel J -
Demi Marie Obenour -
Johannes Süllner