[PATCH v4] crosvm: Rename `--vhost-user-gpu` flag
crosvm was producing warnings when using `--vhost-user-gpu` and `--vhost-user-fs`, of which the former is fixable, but the latter requires some more work. The latter will be patched later on. To mitigate the former, I have adjusted the `crosvm` invocations to look something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, `gpu`, and `$PATH` is the path to the Unix socket. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk> --- The typo gremlins snuck into that last v3 patch, but hopefully v4 will fix it. img/app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/img/app/Makefile b/img/app/Makefile index 2aa78a0..d914cab 100644 --- a/img/app/Makefile +++ b/img/app/Makefile @@ -168,7 +168,7 @@ run-crosvm: $(imgdir)/appvm/blk/root.img start-vhost-user-gpu start-virtiofsd -p "console=ttyS0 root=PARTLABEL=root" \ --net tap-name=tap0 \ --vhost-user-fs build/virtiofsd.sock:virtiofs0 \ - --vhost-user-gpu build/vhost-user-gpu.sock \ + --vhost-user gpu,socket=build/vhost-user-gpu.sock \ --vsock cid=3 \ --serial type=file,hardware=serial,path=build/serial.log \ --serial type=stdout,hardware=virtio-console,stdin=true \ -- 2.44.1
This patch has been committed as cd2ccb597b2d3de088b247a9b0ac6bd630c8d3f2, which can be viewed online at https://spectrum-os.org/git/spectrum/commit/?id=cd2ccb597b2d3de088b247a9b0ac.... This is an automated message. Send comments/questions/requests to: Alyssa Ross <hi@alyssa.is>
Dom Rodriguez <shymega@shymega.org.uk> writes:
crosvm was producing warnings when using `--vhost-user-gpu` and `--vhost-user-fs`, of which the former is fixable, but the latter requires some more work. The latter will be patched later on.
To mitigate the former, I have adjusted the `crosvm` invocations to look something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, `gpu`, and `$PATH` is the path to the Unix socket.
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk> ---
The typo gremlins snuck into that last v3 patch, but hopefully v4 will fix it.
img/app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks! There's also still the --vhost-user-gpu in release/checks/wayland/default.nix.
On 10.11.2024 20:55, Alyssa Ross wrote:
Dom Rodriguez <shymega@shymega.org.uk> writes:
crosvm was producing warnings when using `--vhost-user-gpu` and `--vhost-user-fs`, of which the former is fixable, but the latter requires some more work. The latter will be patched later on.
To mitigate the former, I have adjusted the `crosvm` invocations to look something like `--vhost-user $DEVICE,socket=$PATH`, where `$DEVICE` is, in this case, `gpu`, and `$PATH` is the path to the Unix socket.
Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk> ---
The typo gremlins snuck into that last v3 patch, but hopefully v4 will fix it.
img/app/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks!
There's also still the --vhost-user-gpu in release/checks/wayland/default.nix.
Sharp eyes, as always! Patch submitted. Best wishes, -- Dom Rodriguez
participants (3)
-
Alyssa Ross -
Alyssa Ross -
Dom Rodriguez